summary refs log tree commit diff
path: root/nixos/modules/system/boot/loader
diff options
context:
space:
mode:
authorJosh Cartwright <joshc@eso.teric.us>2014-09-03 05:36:45 +0200
committerJosh Cartwright <joshc@eso.teric.us>2014-09-03 05:36:45 +0200
commit626a666da53229e463549bca0d24e2b21a4801cd (patch)
tree8d0370610fd575b30347c20dd99f53799fedc028 /nixos/modules/system/boot/loader
parent933ac5e9f8cd1f09e649621200dc7053675fe4c1 (diff)
downloadnixlib-626a666da53229e463549bca0d24e2b21a4801cd.tar
nixlib-626a666da53229e463549bca0d24e2b21a4801cd.tar.gz
nixlib-626a666da53229e463549bca0d24e2b21a4801cd.tar.bz2
nixlib-626a666da53229e463549bca0d24e2b21a4801cd.tar.lz
nixlib-626a666da53229e463549bca0d24e2b21a4801cd.tar.xz
nixlib-626a666da53229e463549bca0d24e2b21a4801cd.tar.zst
nixlib-626a666da53229e463549bca0d24e2b21a4801cd.zip
gummiboot/builder: fix timeout setting when unset
The gummiboot-builder.py script is expecting the @timeout@ metavar to be
substituted for either an empty string (in the case where a user has
left the timeout unset) or the actual value set in the system
configuration.

However, the config.boot.loader.gummiboot.timeout option defaults to
'null', and due to the way pkgs.substituteAll works, the substitution
for '@timeout@' is _never_ set to the empty string.  This causes the
builder script to put a bogus line into /boot/loader/loader.conf:

   timeout @timeout@

Fix this by explicitly setting 'timeout' to the empty string when it's
unset in the system configuration.

Signed-off-by: Josh Cartwright <joshc@eso.teric.us>
Diffstat (limited to 'nixos/modules/system/boot/loader')
-rw-r--r--nixos/modules/system/boot/loader/gummiboot/gummiboot.nix2
1 files changed, 1 insertions, 1 deletions
diff --git a/nixos/modules/system/boot/loader/gummiboot/gummiboot.nix b/nixos/modules/system/boot/loader/gummiboot/gummiboot.nix
index e7a481e90a79..003f72b37f9e 100644
--- a/nixos/modules/system/boot/loader/gummiboot/gummiboot.nix
+++ b/nixos/modules/system/boot/loader/gummiboot/gummiboot.nix
@@ -16,7 +16,7 @@ let
 
     nix = config.nix.package;
 
-    inherit (cfg) timeout;
+    timeout = if cfg.timeout != null then cfg.timeout else "";
 
     inherit (efi) efiSysMountPoint canTouchEfiVariables;
   };