diff options
| author | Domen Kožar <domen@dev.si> | 2016-02-28 08:49:55 +0000 |
|---|---|---|
| committer | Domen Kožar <domen@dev.si> | 2016-02-28 08:50:33 +0000 |
| commit | 3c84ae406d80ba01f96a6da27de954b61f0e735b (patch) | |
| tree | 125b5234dd80b43b8b8f0d0494b86c2819bef1e6 /.github | |
| parent | 762678d6af35a5751d33d72fdbabd954f50f702a (diff) | |
| download | nixlib-3c84ae406d80ba01f96a6da27de954b61f0e735b.tar nixlib-3c84ae406d80ba01f96a6da27de954b61f0e735b.tar.gz nixlib-3c84ae406d80ba01f96a6da27de954b61f0e735b.tar.bz2 nixlib-3c84ae406d80ba01f96a6da27de954b61f0e735b.tar.lz nixlib-3c84ae406d80ba01f96a6da27de954b61f0e735b.tar.xz nixlib-3c84ae406d80ba01f96a6da27de954b61f0e735b.tar.zst nixlib-3c84ae406d80ba01f96a6da27de954b61f0e735b.zip | |
PULL_REQUEST_TEMPLATE.md: clarify a few things
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 787524c75758..64904c2908ba 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,15 +1,17 @@ ###### Things done: -- [ ] Tested via `nix.useChroot`. -- [ ] Built on platform(s): . -- [ ] Tested compilation of all pkgs that depend on this change. -- [ ] Tested execution of binary products. +- [ ] Tested using sandboxing (`nix-build --option build-use-chroot true` or [nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS) +- [ ] Built on platform(s): NixOS + OSX + Linux +- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"` +- [ ] Tested execution of all binary files (usually in `./result/bin/`) - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md). -###### Extra -Fixes # . +###### More + +Fixes issue #<insert id> + +cc @<maintainer> -cc @ . --- -_Please note, that points are not mandatory._ +_Please note, that points are not mandatory, but ._ |